Re: Re: [PATCH 1/2] git-gui: fix deleting item from all_remotes variable
- From
Heiko Voigt <hvoigt@hvoigt.net>
- Date
- Feb 13, 2011, 14:05 UTC
- Message-ID
- <20110213140523.GF31986@book.hvoigt.net>
- In-Reply-To
- <AANLkTi=hY1XpBNfhNDfM8kwgnitQXN-97mM-dkhCpTac@mail.gmail.com>
Hi Pat,
On Sun, Feb 13, 2011 at 01:20:14PM +0000, Pat Thoyts wrote:
Show 21 quoted lines
> On 12 February 2011 16:43, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> > lsearch and lreplace both take the variable content as argument and not
> > just their name.
> >
> > Signed-off-by: Heiko Voigt <heiko.voigt@mahr.de>
> > ---
> > lib/remote.tcl | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/remote.tcl b/lib/remote.tcl
> > index b92b429..1383e97 100644
> > --- a/lib/remote.tcl
> > +++ b/lib/remote.tcl
> > @@ -264,8 +264,8 @@ proc remove_remote {name} {
> > unset repo_config(remote.$name.push)
> > }
> >
> > - set i [lsearch -exact all_remotes $name]
> > - lreplace all_remotes $i $i
> > + set i [lsearch -exact $all_remotes $name]
> > + set all_remotes [lreplace $all_remotes $i $i]If you were going to please wait with applying it. I just found another location where this variable is changed in a wrong manner. I will update the patch accordingly.
Cheers Heiko