git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] git-gui: fetch/prune all entry only for more than one entry

From
Pat Thoyts <patthoyts@users.sourceforge.net>
Date
Feb 24, 2011, 00:02 UTC
Message-ID
<87fwrefgfx.fsf@fox.patthoyts.tk>
In-Reply-To
<20110222192835.GA28519@book.hvoigt.net>
Heiko Voigt <hvoigt@hvoigt.net> writes:
Show 35 quoted lines
>In case there is only one remote a fetch/prune all entry
>is redundant.
>
>Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
>---
>
>On Tue, Feb 22, 2011 at 07:36:23PM +0100, Jens Lehmann wrote:
>> 1) It would be nice if the new menu entry would only appear when there
>>    is more than one remote to fetch from.
>
>How about this? Disclaimer: Only superficially tested on OSX.
>
> lib/remote.tcl |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/lib/remote.tcl b/lib/remote.tcl
>index 42d2061..18d3d06 100644
>--- a/lib/remote.tcl
>+++ b/lib/remote.tcl
>@@ -237,13 +237,13 @@ proc update_all_remotes_menu_entry {} {
> 
> 	set have_remote 0
> 	foreach r $all_remotes {
>-		set have_remote 1
>+		incr have_remote
> 	}
> 
> 	set remote_m .mbar.remote
> 	set fetch_m $remote_m.fetch
> 	set prune_m $remote_m.prune
>-	if {$have_remote} {
>+	if {$have_remote > 1} {
> 		make_sure_remote_submenues_exist $remote_m
> 		set index [expr {[$fetch_m type 0] eq "tearoff" ? 1 : 0}]
> 		if {[$fetch_m entrycget $index -label] ne "All"} {

This is fine - applied and checked it on Windows. I'll add a Suggested-by from Jens as this was a response to his request.

-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD
Previous: Heiko VoigtNext: Heiko Voigt
Message 12 of 17 in “git-gui: fix deleting item from all_remotes variable”
  1. 1/2 git-gui: fix deleting item from all_remotes variableHeiko Voigt, Feb 12, 2011
  2. Pat ThoytsFeb 13, 2011
  3. Heiko VoigtFeb 13, 2011
  4. 1/2 git-gui: refactor remote submenu creation into subroutineHeiko Voigt, Feb 13, 2011
  5. 2/2 git-gui: teach fetch/prune menu to do it for all remotesHeiko Voigt, Feb 13, 2011
  6. git-gui: Include version check and test for tearoff menu entryPat Thoyts, Feb 14, 2011
  7. Heiko VoigtFeb 14, 2011
  8. Pat ThoytsFeb 15, 2011
  9. Heiko VoigtFeb 17, 2011
  10. Jens LehmannFeb 22, 2011
  11. 1/2 git-gui: fetch/prune all entry only for more than one entryHeiko Voigt, Feb 22, 2011
  12. Pat ThoytsFeb 24, 2011
  13. 2/2 git-gui: fetch/prune all entry appears lastHeiko Voigt, Feb 22, 2011
  14. Jens LehmannFeb 23, 2011
  15. Pat ThoytsFeb 24, 2011
  16. Heiko VoigtFeb 13, 2011
  17. Heiko VoigtFeb 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.