Re: [PATCH 1/2] git-gui: fix deleting item from all_remotes variable
- From
Pat Thoyts <patthoyts@gmail.com>
- Date
- Feb 13, 2011, 13:20 UTC
- Message-ID
- <AANLkTi=hY1XpBNfhNDfM8kwgnitQXN-97mM-dkhCpTac@mail.gmail.com>
- In-Reply-To
- <20110212164344.GA19433@book.hvoigt.net>
On 12 February 2011 16:43, Heiko Voigt <hvoigt@hvoigt.net> wrote:
Show 27 quoted lines
> lsearch and lreplace both take the variable content as argument and not
> just their name.
>
> Signed-off-by: Heiko Voigt <heiko.voigt@mahr.de>
> ---
> lib/remote.tcl | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/remote.tcl b/lib/remote.tcl
> index b92b429..1383e97 100644
> --- a/lib/remote.tcl
> +++ b/lib/remote.tcl
> @@ -264,8 +264,8 @@ proc remove_remote {name} {
> unset repo_config(remote.$name.push)
> }
>
> - set i [lsearch -exact all_remotes $name]
> - lreplace all_remotes $i $i
> + set i [lsearch -exact $all_remotes $name]
> + set all_remotes [lreplace $all_remotes $i $i]
>
> set remote_m .mbar.remote
> delete_from_menu $remote_m.fetch $name
> --
> 1.7.4.34.gd2cb1
>
>This fix is good and clearly resolves a bug in the tcl code -- however, what does it actually fix in the application? It looks like removing a remote works anyway even though this variable is not being updated. Pat Thoyts