From: Heiko Voigt Date: Mon, 14 Feb 2011 21:31:48 GMT Subject: Re: [PATCH] git-gui: Include version check and test for tearoff menu entry Message-ID: <20110214213148.GB50815@book.hvoigt.net> In-Reply-To: <878vxilndt.fsf_-_@fox.patthoyts.tk> Hi, On Mon, Feb 14, 2011 at 01:03:24PM +0000, Pat Thoyts wrote: > The --all option for git fetch was added in v1.6.6 so ensure we have a usable version before adding > the menu items. > Sometimes people use tearoff menus and these offset the entry indices by one. > > Signed-off-by: Pat Thoyts > --- > > Heiko Voigt writes: > >It just came to my mind that I probably should implement a version check > >of the commandline to ensure that this option is available. Thats why I > >tagged only this patch with RFC. > > > >Cheers Heiko > > The posted patch seems fine except that an error is reported if tearoff > menus are present. So this patch accommodates tearoff's. I looked up > when the --all option was added (1.6.6) and skip adding the menu entry > if we have an older version. > > Seems to do the right thing. Works and looks good to me as well. Did not know about tearoff menues how do you get those? Cheers Heiko P.S.: I discovered a whitespace issue in line 258 which came from my patch. Could you correct that?