git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Re: [PATCH 1/2] git-gui: fix deleting item from all_remotes variable

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
Feb 13, 2011, 13:47 UTC
Message-ID
<20110213134753.GC31986@book.hvoigt.net>
In-Reply-To
<AANLkTi=hY1XpBNfhNDfM8kwgnitQXN-97mM-dkhCpTac@mail.gmail.com>
Hi Pat,
On Sun, Feb 13, 2011 at 01:20:14PM +0000, Pat Thoyts wrote:
> This fix is good and clearly resolves a bug in the tcl code --
> however, what does it actually fix in the application? It looks like
> removing a remote works anyway even though this variable is not being
> updated.

I do not know the other implications but I needed this fix for a patch I wrote. I did not send it because it is quite long and I wanted to wait until my other patches are ok so you do not have to review too much. But since you asked I will reply with the two patches to this email.

Cheers Heiko
Previous: Pat ThoytsNext: Heiko Voigt
Message 3 of 17 in “git-gui: fix deleting item from all_remotes variable”
  1. 1/2 git-gui: fix deleting item from all_remotes variableHeiko Voigt, Feb 12, 2011
  2. Pat ThoytsFeb 13, 2011
  3. Heiko VoigtFeb 13, 2011
  4. 1/2 git-gui: refactor remote submenu creation into subroutineHeiko Voigt, Feb 13, 2011
  5. 2/2 git-gui: teach fetch/prune menu to do it for all remotesHeiko Voigt, Feb 13, 2011
  6. git-gui: Include version check and test for tearoff menu entryPat Thoyts, Feb 14, 2011
  7. Heiko VoigtFeb 14, 2011
  8. Pat ThoytsFeb 15, 2011
  9. Heiko VoigtFeb 17, 2011
  10. Jens LehmannFeb 22, 2011
  11. 1/2 git-gui: fetch/prune all entry only for more than one entryHeiko Voigt, Feb 22, 2011
  12. Pat ThoytsFeb 24, 2011
  13. 2/2 git-gui: fetch/prune all entry appears lastHeiko Voigt, Feb 22, 2011
  14. Jens LehmannFeb 23, 2011
  15. Pat ThoytsFeb 24, 2011
  16. Heiko VoigtFeb 13, 2011
  17. Heiko VoigtFeb 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.