git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] commit: Show the committer ident when is different from the parent

From
Jeff King <peff@peff.net>
Date
Apr 30, 2008, 19:26 UTC
Message-ID
<20080430192639.GC30344@sigill.intra.peff.net>
In-Reply-To
<8aa486160804301223w574fe425n5d0678020ff1e7b4@mail.gmail.com>
On Wed, Apr 30, 2008 at 09:23:43PM +0200, Santi Béjar wrote:
Show 9 quoted lines
> >  I like the idea in general, but the implementation could be refined.
> >  Maybe consider looking at user.name (whether the repo has an ident
> >  set)? This is usually done conciously, and the user wont need this
> >  reminder.
> 
> Maybe only show the committer ident when both happens:
> 
> 1) the committer ident is different from the parent
> 2) the committer ident is set automatically

Honestly, I think just "2)" is probably fine (where automatically presumably means "from GECOS"). I see what you are trying to accomplish with "1)", but it's so workflow specific as to be useless.

> P.D.: Jeff, thanks for the amending patch.
No problem.
-Peff
Previous: Santi BéjarNext: Santi Béjar
Message 9 of 15 in “Show author and/or committer in some cases”
  1. 0/3 Show author and/or committer in some casesSanti Béjar, Apr 30, 2008
  2. 1/3 Preparation to call determine_author_info from prepare_to_commitSanti Béjar, Apr 30, 2008
  3. 2/3 commit: Show author if different from committerSanti Béjar, Apr 30, 2008
  4. 3/3 commit: Show the committer ident when is different from the parentSanti Béjar, Apr 30, 2008
  5. Jeff KingApr 30, 2008
  6. Jeff KingApr 30, 2008
  7. Jeff KingApr 30, 2008
  8. Santi BéjarApr 30, 2008
  9. Jeff KingApr 30, 2008
  10. Santi BéjarMay 1, 2008
  11. Jeff KingMay 1, 2008
  12. Junio C HamanoMay 1, 2008
  13. Jeff KingMay 1, 2008
  14. Santi BéjarMay 2, 2008
  15. Alex RiesenApr 30, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.