git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] commit: Show the committer ident when is different from the parent

From
Jeff King <peff@peff.net>
Date
May 1, 2008, 22:28 UTC
Message-ID
<20080501222801.GA21731@sigill.intra.peff.net>
In-Reply-To
<7vd4o5zw2s.fsf@gitster.siamese.dyndns.org>
On Thu, May 01, 2008 at 12:02:51PM -0700, Junio C Hamano wrote:
Show 5 quoted lines
> Once you have a good algorithm to see when to trigger the warning that the
> user might be using an unintended committer identity, I do not think you
> should refrain from issuing the warning when you see the offending
> committer ident and whose commit you are building on top of should not
> affect it.  Otherwise, the user will get the warning once (or not even get

I think I must not be writing very clearly, because that is basically the same point I have been trying to make in this thread. Santi's original algorithm for warning about the wrong committer ident was to check whether it matched the parent commit. But my point was that is a bad algorithm, because it has way too many false positives (i.e., you will end up showing the committer _all the time_ in many workflows). So the followup was "check this other thing, and also look at whether it matches the parent" to which my response was "why bother checking the parent match then?"

I also think you could argue that we should just show the committer all the time. But I don't think anyone has made that argument.

> I think the other patch about showing the author when you are committing
> other's changes is a good move, by the way.

I agree; it has a very straightforward and sensible algorithm for when to show.

-Peff
Previous: Junio C HamanoNext: Santi Béjar
Message 13 of 15 in “Show author and/or committer in some cases”
  1. 0/3 Show author and/or committer in some casesSanti Béjar, Apr 30, 2008
  2. 1/3 Preparation to call determine_author_info from prepare_to_commitSanti Béjar, Apr 30, 2008
  3. 2/3 commit: Show author if different from committerSanti Béjar, Apr 30, 2008
  4. 3/3 commit: Show the committer ident when is different from the parentSanti Béjar, Apr 30, 2008
  5. Jeff KingApr 30, 2008
  6. Jeff KingApr 30, 2008
  7. Jeff KingApr 30, 2008
  8. Santi BéjarApr 30, 2008
  9. Jeff KingApr 30, 2008
  10. Santi BéjarMay 1, 2008
  11. Jeff KingMay 1, 2008
  12. Junio C HamanoMay 1, 2008
  13. Jeff KingMay 1, 2008
  14. Santi BéjarMay 2, 2008
  15. Alex RiesenApr 30, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.