Re: [PATCH 3/3] commit: Show the committer ident when is different from the parent

From: Santi Béjar <sbejar@gmail.com>
Date: May 2, 2008, 09:25 UTC
Message-ID: <8aa486160805020225p47230100m86f9ee251dabc161@mail.gmail.com>
In-Reply-To: <20080501222801.GA21731@sigill.intra.peff.net>

On Fri, May 2, 2008 at 12:28 AM, Jeff King <peff@peff.net> wrote:

Show 9 quoted lines

> On Thu, May 01, 2008 at 12:02:51PM -0700, Junio C Hamano wrote:
>
>  > Once you have a good algorithm to see when to trigger the warning that the
>  > user might be using an unintended committer identity, I do not think you
>  > should refrain from issuing the warning when you see the offending
>  > committer ident and whose commit you are building on top of should not
>  > affect it.  Otherwise, the user will get the warning once (or not even get
>
>  I think I must not be writing very clearly,

It was clear, but I think there is more than this, especially the definition of what is a wrong committer depends on the user. I was trying to not annoy too much to some users (those who like the automatic committer).

Let's find the definition of "wrong committer":

1) user.{name,email} or GIT_COMMITTER_{NAME,EMAIL} is not a wrong committer.
2) automatic without a domain name (user@hostname.(none)) is a wrong committer.
2) automatic or partially set ident:
    a) wrong committer for some users
    b) right committer for others

I see different strategies. Show the committer:

1) always
2) when user.warn = yes (defaulting to yes)
3) when it is automatic
    a) always
    b) and different from parent
    c) and different from a list of valid committer idents
    d) and when user.WarnAutomatic = yes (defaulting to yes)

(the names of the configs are just ideas)

I prefer in order: 3a, 3d, 2, 1.

>
>  I also think you could argue that we should just show the committer all
>  the time. But I don't think anyone has made that argument.

>From past threads and the "precious screen state" I thought it was

totally discarded.

Santi