From: Jeff King <peff@peff.net>
Date: Wed, 30 Apr 2008 19:26:39 GMT
Subject: Re: [PATCH 3/3] commit: Show the committer ident when is different from the parent
Message-ID: <20080430192639.GC30344@sigill.intra.peff.net>
In-Reply-To: <8aa486160804301223w574fe425n5d0678020ff1e7b4@mail.gmail.com>

On Wed, Apr 30, 2008 at 09:23:43PM +0200, Santi Béjar wrote:

> >  I like the idea in general, but the implementation could be refined.
> >  Maybe consider looking at user.name (whether the repo has an ident
> >  set)? This is usually done conciously, and the user wont need this
> >  reminder.
> 
> Maybe only show the committer ident when both happens:
> 
> 1) the committer ident is different from the parent
> 2) the committer ident is set automatically

Honestly, I think just "2)" is probably fine (where automatically
presumably means "from GECOS"). I see what you are trying to accomplish
with "1)", but it's so workflow specific as to be useless.

> P.D.: Jeff, thanks for the amending patch.

No problem.

-Peff