Re: [PATCH 3/3] commit: Show the committer ident when is different from the parent

From: Santi Béjar <sbejar@gmail.com>
Date: Apr 30, 2008, 19:23 UTC
Message-ID: <8aa486160804301223w574fe425n5d0678020ff1e7b4@mail.gmail.com>
In-Reply-To: <20080430163701.GA6544@sigill.intra.peff.net>

On Wed, Apr 30, 2008 at 6:37 PM, Jeff King <peff@peff.net> wrote:

Show 11 quoted lines

>  Actually, thinking about this a bit more (and using it), I'm not sure
>  that the best rule for showing the committer is "differs from the
>  previous committer." For example, if I am building on Junio's git.git,
>  the committer name is shown, even though I have made many commits in
>  this repo already.
>
>  So if the goal is to show the committer name only when it "matters", I
>  don't think you have succeeded.
>
>  -Peff
>

On Wed, Apr 30, 2008 at 7:52 PM, Alex Riesen <raa.lkml@gmail.com> wrote:

>  I like the idea in general, but the implementation could be refined.
>  Maybe consider looking at user.name (whether the repo has an ident
>  set)? This is usually done conciously, and the user wont need this
>  reminder.

Maybe only show the committer ident when both happens:

1) the committer ident is different from the parent
2) the committer ident is set automatically

Santi

P.D.: Jeff, thanks for the amending patch.