Re: [PATCH 3/3] commit: Show the committer ident when is different from the parent

From: Jeff King <peff@peff.net>
Date: May 1, 2008, 13:51 UTC
Message-ID: <20080501135109.GA10135@sigill.intra.peff.net>
In-Reply-To: <8aa486160805010134l4746f9afhec546a9d49fd7a6d@mail.gmail.com>

On Thu, May 01, 2008 at 10:34:44AM +0200, Santi Béjar wrote:

Show 10 quoted lines

> >  > 1) the committer ident is different from the parent
> >  > 2) the committer ident is set automatically
> >
> >  Honestly, I think just "2)" is probably fine (where automatically
> >  presumably means "from GECOS"). I see what you are trying to accomplish
> >  with "1)", but it's so workflow specific as to be useless.
> 
> I don't see "1) as workflow specific, it is there to minimize the
> number of time it is shown, ie somebody might prefer the automatic
> ident, so as long as it does not change it is not shown.

Yes, but whether it actually succeeds in minimizing is dependent on the workflow of the user. I.e., it works great if I tend to build on small, personal repositories (or topic branches), or if I tend to receive other people's work by patches that I commit myself. But if I am pulling from somebody else's repo (as many of us do from git.git), or if I use a shared repo with the other committers, then I am very likely to be building on a parent that was committed by somebody else (and consequently will see the committer mentioned way more often than was intended).

-Peff