Re: [PATCH 1/5] Internationalization of git-gui

From: Christian Stimming <stimming@tuhh.de>
Date: Jul 23, 2007, 19:23 UTC
Message-ID: <200707232123.01682.stimming@tuhh.de>
In-Reply-To: <20070722073806.GW32566@spearce.org>

Am Sonntag, 22. Juli 2007 09:38 schrieb Shawn O. Pearce:

Show 11 quoted lines

> > +## Internationalization (i18n) through msgcat and gettext. See
> > +## http://www.gnu.org/software/gettext/manual/html_node/Tcl.html
> > +package require msgcat
> > +::msgcat::mcload [file join $oguilib msgs]
> > +namespace import ::msgcat::mc
>
> Thanks.  We'll probably also want to modify the lib/class.tcl to
> import ::msgcat::mc into the class namespace when it creates it.
> I use that class thing throught most of git-gui, especially for
> UI code.  About 50% of git-gui has been converted to use class,
> the other 50% is just global and is still in git-gui.sh.  ;-)

As I was adding the markup in all the other files, I didn't have to add another import statement anywhere else. Seems like the global mc procedure works just fine.

In other words, if you think the mc procedure should be imported in another place as well, please do so because I don't know your future plans with class structure (and I also don't need to know for adding the i18n support right now).

Thanks,

Christian