Re: [PATCHv2] connect: display connection progress

From: Michael S. Tsirkin <mst@dev.mellanox.co.il>
Date: May 10, 2007, 15:02 UTC
Message-ID: <20070510150225.GS13655@mellanox.co.il>
In-Reply-To: <81b0412b0705100752wa6dec37t787ccd61266f8944@mail.gmail.com>

Show 13 quoted lines

> Quoting Alex Riesen <raa.lkml@gmail.com>:
> Subject: Re: [PATCHv2] connect: display connection progress
> 
> On 5/10/07, Michael S. Tsirkin <mst@dev.mellanox.co.il> wrote:
> >So, that's why the "connecting" message belongs in the default setup
> >(it can hang there for minutes), IP and such technicalia
> >belong with -v, and -q would only print data on connection error.
> 
> How about a config option? So that people working with
> repos connected through fast links (say, in local network or
> even locally on the same system) are not bothered by the
> "connecting" messages (they're is useless then, local networks
> usually work).

Do you really have git servers accessed over a local lan or on local system? I just use ssh in this case, and I think that's the common case ...

I think making it possible to make -q a config option would be useful, though.

We *could* try doing something smart with non-blocking connect + select, and only print the message if it takes > 1 second. Are you sure it's worth the complication?

-- 
MST