Re: [PATCHv2] connect: display connection progress

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: May 10, 2007, 16:05 UTC
Message-ID: <alpine.LFD.0.98.0705100901320.3986@woody.linux-foundation.org>
In-Reply-To: <81b0412b0705100439j4e6b072bk1ba19a4f971e5d0c@mail.gmail.com>

On Thu, 10 May 2007, Alex Riesen wrote:

> 
> There is only one bit of flags ever used. What are the others for?

I actually think it tends to be better to have a "flags" field rather than a boolean, even if it only ends up having one flag.

> Why use negative logic?

This one I agree with. Ity would be nicer with CONNECT_VERBOSE than with NET_QUIET, and having the tests be

	if (flags & CONNECT_VERBOSE)
		..

instead.

> What was wrong with plain "int verbose"?

I could see wanting to add flags to do things like disable insecure connections etc, so there's certainly nothing saying that "verbose" is the only valid way to do things.

> What addresses were tried by connect?

That would be _really_ verbose. Maybe a CONNECT_EXTRA_VERBOSE?

		Linus