Re: [PATCHv2] connect: display connection progress

From: Michael S. Tsirkin <mst@dev.mellanox.co.il>
Date: May 10, 2007, 12:08 UTC
Message-ID: <20070510120802.GG13655@mellanox.co.il>
In-Reply-To: <81b0412b0705100439j4e6b072bk1ba19a4f971e5d0c@mail.gmail.com>

Show 8 quoted lines

> Quoting Alex Riesen <raa.lkml@gmail.com>:
> Subject: Re: [PATCHv2] connect: display connection progress
> 
> On 5/10/07, Michael S. Tsirkin <mst@dev.mellanox.co.il> wrote:
> >-static int git_tcp_connect_sock(char *host)
> >+static int git_tcp_connect_sock(char *host, int flags)
> 
> There is only one bit of flags ever used. What are the others for?

Hmm, I thought it's easier to read 
git_tcp_connect_sock(host, NET_QUIET)
	than
git_tcp_connect_sock(host, 1)

but maybe that's overdesign.

> Why use negative logic?
> What was wrong with plain "int verbose"?

I want the default to report connections, and -q to silence them. Maybe "int quiet"?

> What addresses were tried by connect?

You are speaking about your patch reporting the IP on failure? I think it makes sense, but it's a separate issue, isn't it?

-- 
MST