Re: [PATCHv2] connect: display connection progress

From: Michael S. Tsirkin <mst@dev.mellanox.co.il>
Date: May 10, 2007, 14:39 UTC
Message-ID: <20070510143913.GF22029@mellanox.co.il>
In-Reply-To: <81b0412b0705100716t680290a3qd1d10cf588a65f5a@mail.gmail.com>

Show 7 quoted lines

> >> How about cleaning up this (reduce the amount of date
> >> on screen)
> >
> >Isn't this why we have -q?
> 
> Only fetch-pack has -q (and -v, which is confusing to
> say the least).

I find it quite proper to have both. I would expect the following:

- git fetch normally displays progress meter, possibly
  tells me what stage it's in (connecting/downloading ....)
  so I know it's not hung.
- git fetch -q only tells me about errors/exceptional events
  good e.g. for scripts.
- git fetch -v gives a lot of detail useful for debugging
  only used if I see problems and want to debug.

Isn't this what's going on?

So, that's why the "connecting" message belongs in the default setup
(it can hang there for minutes), IP and such technicalia
belong with -v, and -q would only print data on connection error.

-- 
MST