From: Michael S. Tsirkin Date: Thu, 10 May 2007 15:02:25 GMT Subject: Re: [PATCHv2] connect: display connection progress Message-ID: <20070510150225.GS13655@mellanox.co.il> In-Reply-To: <81b0412b0705100752wa6dec37t787ccd61266f8944@mail.gmail.com> > Quoting Alex Riesen : > Subject: Re: [PATCHv2] connect: display connection progress > > On 5/10/07, Michael S. Tsirkin wrote: > >So, that's why the "connecting" message belongs in the default setup > >(it can hang there for minutes), IP and such technicalia > >belong with -v, and -q would only print data on connection error. > > How about a config option? So that people working with > repos connected through fast links (say, in local network or > even locally on the same system) are not bothered by the > "connecting" messages (they're is useless then, local networks > usually work). Do you really have git servers accessed over a local lan or on local system? I just use ssh in this case, and I think that's the common case ... I think making it possible to make -q a config option would be useful, though. We *could* try doing something smart with non-blocking connect + select, and only print the message if it takes > 1 second. Are you sure it's worth the complication? -- MST