Re: [PATCHv2] connect: display connection progress

From: Alex Riesen <raa.lkml@gmail.com>
Date: May 10, 2007, 13:33 UTC
Message-ID: <81b0412b0705100633t61ac0309jfc8536b30244adf6@mail.gmail.com>
In-Reply-To: <20070510122550.GJ13655@mellanox.co.il>

On 5/10/07, Michael S. Tsirkin <mst@dev.mellanox.co.il> wrote:

Show 8 quoted lines

> > >> What addresses were tried by connect?
> > >
> > >You are speaking about your patch reporting the IP on failure?
> >
> > Yes. Not on failure (not only). Every time an address is tried
> > to connect.
>
> Why not only on failure? IP addresses look ugly.

So you can see DNS problems you wanted to uncover. DNS is all about mapping names to that ugly IP. And DNS _problems_ often manifest themselves by mapping the name to an unexpected IP. Now that's really ugly

Show 7 quoted lines

> > >I think it makes sense, but it's a separate issue, isn't it?
> >
> > You are just about to make git_tcp_connect verbose,
> > are you not?
>
> Only if the flag is set. So git-fetch without -q qill be more verbose -
> but it already spits out a fair amount of data on screen.

And so you added some more? Does not sound logical.

How about cleaning up this (reduce the amount of date on screen) and adding another verbosity level (with your messages and IP) instead?