Re: Rss produced by git is not valid xml?
- From
- Ismail Donmez <ismail@uludag.org.tr>
- Date
- Nov 18, 2005, 21:29 UTC
- Message-ID
- <200511182329.52368.ismail@uludag.org.tr>
- In-Reply-To
- <7v7jb5hcm2.fsf@assigned-by-dhcp.cox.net>
On Friday 18 November 2005 23:25, you wrote:
Show 26 quoted lines
> Ismail Donmez <ismail@uludag.org.tr> writes: > >> I agree that UTF-8 is a good idea, but that's a totally different > >> argument. > > > > Maybe you could officially require all commit messages to be UTF-8 then > > the problem would be just solved for future commits at least. Until then > > it should be workarounded in gitweb I guess. > > No, that's something I will *not* do. > > Linus is right --- he is always right but he is slightly more > right than he usually is in this particular case ;-). > > We allow any 8-bit data in commit log messages. We even make it > easier to use utf-8 than other encodings, and we encourage use > of utf-8 for obvious reasons. But we do not go further than > that. Any patch to change commit-tree.c to reject binary data > in a commit log message that utf-8 validator chokes at *will* be > rejected. > > Go back to the list archive. Dig out messages on this topic. > Summarize the ones that say why we encourage utf-8 in textual > commit log messages, submit a patch to add that to > Documentation/howto/ or perhaps Documentation/tutorial.txt, to > further encourage people to use utf-8. Just do not forbid non > utf-8 text nor binary data in general.
Your produced XML is NOT valid then. You put encoding=utf-8 and then put latin-1 encoded data in it. You SHOULD NOT do that. Either put latin-1 as encoding in the RSS because you say its the way data should be else encode non-utf stuff to be utf-8.
Regards, ismail