git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] contrib: add credential helper for libsecret

From
Dennis Kaarsemaker <dennis@kaarsemaker.net>
Date
Oct 11, 2016, 15:01 UTC
Message-ID
<1476198080.3876.8.camel@kaarsemaker.net>
In-Reply-To
<20161009123417.147239-1-grawity@gmail.com>
On Sun, 2016-10-09 at 15:34 +0300, Mantas Mikulėnas wrote:
Show 5 quoted lines
> +		s = g_hash_table_lookup(attributes, "user");
> +		if (s) {
> +			g_free(c->username);
> +			c->username = g_strdup(s);
> +		}

This always overwrites c->username, the original gnome-keyring version only does that when the username isn't set. Other than that it looks good to me.

Reviewed-by: Dennis Kaarsemaker <dennis@kaarsemaker.net>
Tested-by: Dennis Kaarsemaker <dennis@kaarsemaker.net>
D.
Previous: Dennis KaarsemakerNext: Junio C Hamano
Message 6 of 13 in “contrib: add credential helper for libsecret”
  1. contrib: add credential helper for libsecretMantas Mikulėnas, Oct 9, 2016
  2. Jeff KingOct 10, 2016
  3. Dennis KaarsemakerOct 10, 2016
  4. Jeff KingOct 10, 2016
  5. Dennis KaarsemakerOct 11, 2016
  6. Dennis KaarsemakerOct 11, 2016
  7. Junio C HamanoOct 11, 2016
  8. Mantas MikulėnasOct 11, 2016
  9. Mantas MikulėnasOct 11, 2016
  10. Dennis KaarsemakerOct 11, 2016
  11. Junio C HamanoOct 11, 2016
  12. Junio C HamanoOct 11, 2016
  13. Dennis KaarsemakerOct 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.