From: Dennis Kaarsemaker <dennis@kaarsemaker.net>
Date: Tue, 11 Oct 2016 15:01:20 GMT
Subject: Re: [PATCH] contrib: add credential helper for libsecret
Message-ID: <1476198080.3876.8.camel@kaarsemaker.net>
In-Reply-To: <20161009123417.147239-1-grawity@gmail.com>

On Sun, 2016-10-09 at 15:34 +0300, Mantas Mikulėnas wrote:

> +		s = g_hash_table_lookup(attributes, "user");
> +		if (s) {
> +			g_free(c->username);
> +			c->username = g_strdup(s);
> +		}

This always overwrites c->username, the original gnome-keyring version
only does that when the username isn't set. Other than that it looks
good to me.

Reviewed-by: Dennis Kaarsemaker <dennis@kaarsemaker.net>
Tested-by: Dennis Kaarsemaker <dennis@kaarsemaker.net>

D.