git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] contrib: add credential helper for libsecret

From
Mantas Mikulėnas <grawity@gmail.com>
Date
Oct 11, 2016, 19:48 UTC
Message-ID
<c87e4dd4-7253-d7c2-010b-6d8c7f587093@gmail.com>
In-Reply-To
<xmqqoa2q8ypl.fsf@gitster.mtv.corp.google.com>
On 2016-10-11 22:36, Junio C Hamano wrote:
Show 5 quoted lines
> Thanks for a review.  I'll wait until one of (1) a squashable patch
> to address the "we do not want unconditional overwrite" issue, (2) a
> reroll from Mantas to do the same, or (3) a counter-argument from
> somebody to explain why unconditional overwrite is a good idea here
> (but not in the original) appears.

I overlooked that. I can write a patch, but it shouldn't make any difference in practice – if c->username *was* set, then it would also get added to the search attribute list, therefore the search couldn't possibly return any results with a different username anyway.

-- 
Mantas Mikulėnas <grawity@gmail.com>
Previous: Junio C HamanoNext: Mantas Mikulėnas
Message 8 of 13 in “contrib: add credential helper for libsecret”
  1. contrib: add credential helper for libsecretMantas Mikulėnas, Oct 9, 2016
  2. Jeff KingOct 10, 2016
  3. Dennis KaarsemakerOct 10, 2016
  4. Jeff KingOct 10, 2016
  5. Dennis KaarsemakerOct 11, 2016
  6. Dennis KaarsemakerOct 11, 2016
  7. Junio C HamanoOct 11, 2016
  8. Mantas MikulėnasOct 11, 2016
  9. Mantas MikulėnasOct 11, 2016
  10. Dennis KaarsemakerOct 11, 2016
  11. Junio C HamanoOct 11, 2016
  12. Junio C HamanoOct 11, 2016
  13. Dennis KaarsemakerOct 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.