git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] contrib: add credential helper for libsecret

From
Jeff King <peff@peff.net>
Date
Oct 10, 2016, 18:34 UTC
Message-ID
<20161010183410.dzuqxtms636euxbk@sigill.intra.peff.net>
In-Reply-To
<20161009123417.147239-1-grawity@gmail.com>
On Sun, Oct 09, 2016 at 03:34:17PM +0300, Mantas Mikulėnas wrote:
> This is based on the existing gnome-keyring helper, but instead of
> libgnome-keyring (which was specific to GNOME and is deprecated), it
> uses libsecret which can support other implementations of XDG Secret
> Service API.

Thanks for working on this; I'm happy to see credential helpers for as many storage APIs as possible.

> Passes t0303-credential-external.sh.

Thank you for running that, as my first question would have been about its results. :)

I don't know much about the Secret Service API, nor do I run a desktop environment which provides the server side of it. But the code looks straightforward and reasonable, it passes t0303, and presumably it is working for you. So this seems worth merging to me.

-Peff
Previous: Mantas MikulėnasNext: Dennis Kaarsemaker
Message 2 of 13 in “contrib: add credential helper for libsecret”
  1. contrib: add credential helper for libsecretMantas Mikulėnas, Oct 9, 2016
  2. Jeff KingOct 10, 2016
  3. Dennis KaarsemakerOct 10, 2016
  4. Jeff KingOct 10, 2016
  5. Dennis KaarsemakerOct 11, 2016
  6. Dennis KaarsemakerOct 11, 2016
  7. Junio C HamanoOct 11, 2016
  8. Mantas MikulėnasOct 11, 2016
  9. Mantas MikulėnasOct 11, 2016
  10. Dennis KaarsemakerOct 11, 2016
  11. Junio C HamanoOct 11, 2016
  12. Junio C HamanoOct 11, 2016
  13. Dennis KaarsemakerOct 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.