Re: [PATCH] contrib: add credential helper for libsecret
- From
Mantas Mikulėnas <grawity@gmail.com>
- Date
- Oct 11, 2016, 19:59 UTC
- Message-ID
- <61eb8570-52bc-0059-9c81-ad1d66da12ac@gmail.com>
- In-Reply-To
- <c87e4dd4-7253-d7c2-010b-6d8c7f587093@gmail.com>
On 2016-10-11 22:48, Mantas Mikulėnas wrote:
Show 11 quoted lines
> On 2016-10-11 22:36, Junio C Hamano wrote: >> Thanks for a review. I'll wait until one of (1) a squashable patch >> to address the "we do not want unconditional overwrite" issue, (2) a >> reroll from Mantas to do the same, or (3) a counter-argument from >> somebody to explain why unconditional overwrite is a good idea here >> (but not in the original) appears. > > I overlooked that. I can write a patch, but it shouldn't make any > difference in practice – if c->username *was* set, then it would also > get added to the search attribute list, therefore the search couldn't > possibly return any results with a different username anyway.
On a second thought, it doesn't actually make sense _not_ to override the username. Let's say the search query *somehow* returned a different account than requested. With the original (gnome-keyring helper's) behavior, the final output would have the old account's username, but the new account's password – which has very little chance of working.
-- Mantas Mikulėnas <grawity@gmail.com>