git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 00/45] Massive improvents to rebase and cherry-pick

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Jun 9, 2013, 16:40 UTC
Message-ID
<1370796057-25312-1-git-send-email-felipe.contreras@gmail.com>
Hi,

These are improvements to 'git rebase' by using a much improved 'git cherry-pick'. I already sent some of these, but they have been revamped.

These changes require reorganization of the code in order to have a builtin/lib.a library.

A new builtin/rewrite.c helper is added, and builtin/commit updated to use that.

A new git-rebase--cherypick mode is added, and it replaces git-rebase--am and git-rebase--merge.

I also added the new rebase tests by Martin von Zweigbergk to make sure everything works, and in fact, it works better than before, since now all the rebase modes are consistent with each other.

I don't have any hopes of these getting merged, because people have no interest in fixing the ./*.o ./builin/*.o divide problem, only interested in arguing that libgit.a is not a real library, and it should never be. So my obviously cleanup is rejected.

Felipe Contreras (38):
  build: generate and clean test scripts
  build: do not install git-remote-testgit
  build: trivial cleanup
  build: add builtin lib
  log-tree: remove dependency from sequencer
  Move sequencer to builtin
  unpack-trees: plug a memory leak
  read-cache: plug a few leaks
  sequencer: remove useless indentation
  sequencer: trivial fix
  cherry-pick: don't barf when there's nothing to do
  cherry-pick: add --skip-empty option
  revert/cherry-pick: add --quiet option
  revert/cherry-pick: add --skip option
  builtin: add rewrite helper
  cherry-pick: store rewritten commits
  cherry-pick: don't store skipped commit
  builtin: move run_rewrite_hook() to rewrite.c
  builtin: add copy_rewrite_notes()
  cherry-pick: copy notes and run hooks
  cherry-pick: add --action-name option
  cherry-pick: remember rerere-autoupdate
  rebase: split the cherry-pick stuff
  rebase: cherry-pick: fix mode storage
  rebase: cherry-pick: fix sequence continuation
  rebase: cherry-pick: fix abort of cherry mode
  rebase: cherry-pick: fix command invocations
  rebase: cherry-pick: fix status messages
  rebase: cherry-pick: automatically commit stage
  rebase: cherry-pick: set correct action-name
  rebase: trivial cleanup
  rebase: use 'cherrypick' mode instead of 'am'
  rebase: cherry-pick: fix for shell prompt
  rebase: cherry-pick: add merge options
  rebase: remove merge mode
  rebase: cherry-pick: add copyright
  tests: fix autostash
  tests: update topology tests
Martin von Zweigbergk (7):
  add simple tests of consistency across rebase types
  add tests for rebasing with patch-equivalence present
  add tests for rebasing of empty commits
  add tests for rebasing root
  add tests for rebasing merged history
  t3406: modernize style
  tests: move test for rebase messages from t3400 to t3406
 .gitignore                             |   1 +
 Documentation/git-cherry-pick.txt      |  10 +-
 Documentation/git-revert.txt           |   7 +-
 Documentation/sequencer.txt            |   3 +
 Makefile                               |  31 +--
 builtin/commit.c                       |  46 +----
 builtin/revert.c                       |  17 ++
 builtin/rewrite.c                      | 124 ++++++++++++
 builtin/rewrite.h                      |  20 ++
 sequencer.c => builtin/sequencer.c     | 263 ++++++++++---------------
 sequencer.h => builtin/sequencer.h     |  12 +-
 contrib/completion/git-prompt.sh       |   4 +-
 git-rebase--am.sh                      |  12 +-
 git-rebase--cherrypick.sh              |  72 +++++++
 git-rebase--interactive.sh             |   4 +-
 git-rebase--merge.sh                   | 151 --------------
 git-rebase.sh                          |  16 +-
 log-tree.c                             | 161 ++++++++++++++-
 log-tree.h                             |   3 +
 read-cache.c                           |   4 +
 t/lib-rebase.sh                        |  33 ++++
 t/t3400-rebase.sh                      |  53 +----
 t/t3401-rebase-partial.sh              |  69 -------
 t/t3404-rebase-interactive.sh          |  10 +-
 t/t3406-rebase-message.sh              |  56 +++---
 t/t3407-rebase-abort.sh                |   2 +-
 t/t3409-rebase-preserve-merges.sh      |  53 -----
 t/t3420-rebase-autostash.sh            |   5 +-
 t/t3421-rebase-topology-linear.sh      | 350 +++++++++++++++++++++++++++++++++
 t/t3425-rebase-topology-merges.sh      | 255 ++++++++++++++++++++++++
 t/t3508-cherry-pick-many-commits.sh    |  13 ++
 t/t3510-cherry-pick-sequence.sh        |  14 +-
 t/t5520-pull.sh                        |   2 +-
 t/t9106-git-svn-commit-diff-clobber.sh |   2 +-
 t/t9903-bash-prompt.sh                 |   2 +-
 unpack-trees.c                         |   4 +-
 36 files changed, 1268 insertions(+), 616 deletions(-)
 create mode 100644 builtin/rewrite.c
 create mode 100644 builtin/rewrite.h
 rename sequencer.c => builtin/sequencer.c (86%)
 rename sequencer.h => builtin/sequencer.h (86%)
 create mode 100644 git-rebase--cherrypick.sh
 delete mode 100644 git-rebase--merge.sh
 delete mode 100755 t/t3401-rebase-partial.sh
 create mode 100755 t/t3421-rebase-topology-linear.sh
 create mode 100755 t/t3425-rebase-topology-merges.sh
-- 
1.8.3.698.g079b096
Next: Felipe Contreras
Message 1 of 86 in “Massive improvents to rebase and cherry-pick”
  1. 00/45 Massive improvents to rebase and cherry-pickFelipe Contreras, Jun 9, 2013
  2. 01/45 build: generate and clean test scriptsFelipe Contreras, Jun 9, 2013
  3. 02/45 build: do not install git-remote-testgitFelipe Contreras, Jun 9, 2013
  4. 03/45 build: trivial cleanupFelipe Contreras, Jun 9, 2013
  5. SZEDER GáborJun 9, 2013
  6. 04/45 build: add builtin libFelipe Contreras, Jun 9, 2013
  7. 05/45 log-tree: remove dependency from sequencerFelipe Contreras, Jun 9, 2013
  8. 06/45 Move sequencer to builtinFelipe Contreras, Jun 9, 2013
  9. Antoine PelisseJun 9, 2013
  10. Felipe ContrerasJun 9, 2013
  11. Ramkumar RamachandraJun 9, 2013
  12. Antoine PelisseJun 9, 2013
  13. 07/45 unpack-trees: plug a memory leakFelipe Contreras, Jun 9, 2013
  14. 08/45 read-cache: plug a few leaksFelipe Contreras, Jun 9, 2013
  15. 09/45 sequencer: remove useless indentationFelipe Contreras, Jun 9, 2013
  16. Fredrik GustafssonJun 9, 2013
  17. Felipe ContrerasJun 9, 2013
  18. Fredrik GustafssonJun 9, 2013
  19. Felipe ContrerasJun 9, 2013
  20. Fredrik GustafssonJun 9, 2013
  21. 10/45 sequencer: trivial fixFelipe Contreras, Jun 9, 2013
  22. SZEDER GáborJun 9, 2013
  23. Felipe ContrerasJun 9, 2013
  24. SZEDER GáborJun 9, 2013
  25. John KeepingJun 9, 2013
  26. Felipe ContrerasJun 9, 2013
  27. John KeepingJun 9, 2013
  28. Felipe ContrerasJun 9, 2013
  29. SZEDER GáborJun 9, 2013
  30. Felipe ContrerasJun 9, 2013
  31. SZEDER GáborJun 9, 2013
  32. Felipe ContrerasJun 9, 2013
  33. Philip OakleyJun 9, 2013
  34. 11/45 cherry-pick: don't barf when there's nothing to doFelipe Contreras, Jun 9, 2013
  35. Fredrik GustafssonJun 9, 2013
  36. Felipe ContrerasJun 9, 2013
  37. 12/45 cherry-pick: add --skip-empty optionFelipe Contreras, Jun 9, 2013
  38. 13/45 revert/cherry-pick: add --quiet optionFelipe Contreras, Jun 9, 2013
  39. 14/45 revert/cherry-pick: add --skip optionFelipe Contreras, Jun 9, 2013
  40. 15/45 builtin: add rewrite helperFelipe Contreras, Jun 9, 2013
  41. 16/45 cherry-pick: store rewritten commitsFelipe Contreras, Jun 9, 2013
  42. 17/45 cherry-pick: don't store skipped commitFelipe Contreras, Jun 9, 2013
  43. 18/45 builtin: move run_rewrite_hook() to rewrite.cFelipe Contreras, Jun 9, 2013
  44. 19/45 builtin: add copy_rewrite_notes()Felipe Contreras, Jun 9, 2013
  45. 20/45 cherry-pick: copy notes and run hooksFelipe Contreras, Jun 9, 2013
  46. Thomas RastJun 9, 2013
  47. Felipe ContrerasJun 9, 2013
  48. 21/45 cherry-pick: add --action-name optionFelipe Contreras, Jun 9, 2013
  49. 22/45 cherry-pick: remember rerere-autoupdateFelipe Contreras, Jun 9, 2013
  50. 23/45 rebase: split the cherry-pick stuffFelipe Contreras, Jun 9, 2013
  51. 24/45 rebase: cherry-pick: fix mode storageFelipe Contreras, Jun 9, 2013
  52. 25/45 rebase: cherry-pick: fix sequence continuationFelipe Contreras, Jun 9, 2013
  53. 26/45 rebase: cherry-pick: fix abort of cherry modeFelipe Contreras, Jun 9, 2013
  54. 27/45 rebase: cherry-pick: fix command invocationsFelipe Contreras, Jun 9, 2013
  55. 28/45 rebase: cherry-pick: fix status messagesFelipe Contreras, Jun 9, 2013
  56. 29/45 rebase: cherry-pick: automatically commit stageFelipe Contreras, Jun 9, 2013
  57. 30/45 rebase: cherry-pick: set correct action-nameFelipe Contreras, Jun 9, 2013
  58. 31/45 rebase: trivial cleanupFelipe Contreras, Jun 9, 2013
  59. Fredrik GustafssonJun 9, 2013
  60. Junio C HamanoJun 11, 2013
  61. Fredrik GustafssonJun 11, 2013
  62. Felipe ContrerasJun 11, 2013
  63. Fredrik GustafssonJun 11, 2013
  64. Felipe ContrerasJun 11, 2013
  65. Fredrik GustafssonJun 11, 2013
  66. Felipe ContrerasJun 11, 2013
  67. 32/45 rebase: use 'cherrypick' mode instead of 'am'Felipe Contreras, Jun 9, 2013
  68. 33/45 rebase: cherry-pick: fix for shell promptFelipe Contreras, Jun 9, 2013
  69. 34/45 rebase: cherry-pick: add merge optionsFelipe Contreras, Jun 9, 2013
  70. 35/45 rebase: remove merge modeFelipe Contreras, Jun 9, 2013
  71. 36/45 rebase: cherry-pick: add copyrightFelipe Contreras, Jun 9, 2013
  72. 37/45 tests: fix autostashFelipe Contreras, Jun 9, 2013
  73. 38/45 add simple tests of consistency across rebase typesFelipe Contreras, Jun 9, 2013
  74. 39/45 add tests for rebasing with patch-equivalence presentFelipe Contreras, Jun 9, 2013
  75. 40/45 add tests for rebasing of empty commitsFelipe Contreras, Jun 9, 2013
  76. 41/45 add tests for rebasing rootFelipe Contreras, Jun 9, 2013
  77. 42/45 add tests for rebasing merged historyFelipe Contreras, Jun 9, 2013
  78. Thomas RastJun 9, 2013
  79. Felipe ContrerasJun 9, 2013
  80. Thomas RastJun 9, 2013
  81. Felipe ContrerasJun 9, 2013
  82. 43/45 t3406: modernize styleFelipe Contreras, Jun 9, 2013
  83. 44/45 tests: move test for rebase messages from t3400 to t3406Felipe Contreras, Jun 9, 2013
  84. 45/45 tests: update topology testsFelipe Contreras, Jun 9, 2013
  85. Martin von ZweigbergkJun 11, 2013
  86. Felipe ContrerasJun 11, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.