From: Drew Northup Date: Tue, 21 Dec 2010 15:19:10 GMT Subject: Re: [PATCH] trace.c: mark file-local function static Message-ID: <1292944750.26698.16.camel@drew-northup.unet.maine.edu> In-Reply-To: On Tue, 2010-12-21 at 21:52 +0700, Nguyen Thai Ngoc Duy wrote: > On Mon, Dec 20, 2010 at 11:53 PM, Drew Northup wrote: > Yeah I would expect somebody reverting this patch _if_ this function > is useful outside trace.c again. On the other hand, this patch saves > do_nothing from global namespace so somewhere, some time, somebody can > use it. > > This is pretty much a clean-up patch from my perspective. Do we really > need two paragraph explanation for marking a function static? No, but 1 sentence would be dandy. -- -Drew Northup N1XIM AKA RvnPhnx on OPN ________________________________________________ "As opposed to vegetable or mineral error?" -John Pescatore, SANS NewsBites Vol. 12 Num. 59