Re: [PATCH v2] git-p4: add P4 jobs to git commit message

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 19, 2016, 21:39 UTC
Message-ID: <xmqqzispxoqt.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CABEqOBx4vCUpYTGYM9VF6QHxGGgQSG5APSHymtbV7uVxAbU+ow@mail.gmail.com>

Jan Durovec <jan.durovec@gmail.com> writes:

Show 16 quoted lines

> On Tue, Apr 19, 2016 at 11:09 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
>> For a series this small it does not matter, but anything longer it
>> would be easier to review with a cover letter (i.e. [PATCH 0/N]).  I
>> do not know if submitGit lets us do that, though.
>
> There's a comment on PR itself (in addition to individual commits) so
> theoretically it could.
>
> It seems that for [PATCH ... n/m] e-mails the commit messages are used,
> so there's no reason why the PR comment couldn't be used for a cover
> letter.
>
> In this case the PR comment was the same as for one of the commits.
> Maybe submitGit tried to be smart there? Or maybe it just really
> doesn't support it (yet?).

In any case, I've queued the updated ones as they looked good. Thanks.

By the way, you may or may not have noticed that I've been reordering the lines of your message quoted in my responses; around here, top-posting is frowned upon.