Re: [PATCH v2] git-p4: add P4 jobs to git commit message
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 19, 2016, 16:45 UTC
- Message-ID
- <xmqqfuuh35v5.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CAE5ih7-2mefGwfXRhvQZJFPD4QYAzZ1jYG82s6cnDzWVCiDS8w@mail.gmail.com>
Luke Diamand <luke@diamand.org> writes:
Show 8 quoted lines
>> I am not familiar with "Perforce jobs", but I assume that they are >> always named as "job" + small non-negative integer in a dense way >> and it is OK for this loop to always begin at 0 and immediately stop >> when job + num does not exist (i.e. if job7 is missing, it is >> guaranteed that we will not see job8). > > This is OK - P4 jobs have arbitrary names, but this code is just > extracting an array of them from the commit by index.
Ah, thanks, that is what I was missing and this part of the code makes perfect sense to me now.