git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] git-p4: add P4 jobs to git commit message

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 19, 2016, 16:45 UTC
Message-ID
<xmqqfuuh35v5.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAE5ih7-2mefGwfXRhvQZJFPD4QYAzZ1jYG82s6cnDzWVCiDS8w@mail.gmail.com>
Luke Diamand <luke@diamand.org> writes:
Show 8 quoted lines
>> I am not familiar with "Perforce jobs", but I assume that they are
>> always named as "job" + small non-negative integer in a dense way
>> and it is OK for this loop to always begin at 0 and immediately stop
>> when job + num does not exist (i.e. if job7 is missing, it is
>> guaranteed that we will not see job8).
>
> This is OK - P4 jobs have arbitrary names, but this code is just
> extracting an array of them from the commit by index.

Ah, thanks, that is what I was missing and this part of the code makes perfect sense to me now.

Previous: Luke DiamandNext: Jan Durovec
Message 4 of 21 in “git-p4: add P4 jobs to git commit message”
  1. git-p4: add P4 jobs to git commit messageJan Durovec, Apr 16, 2016
  2. Junio C HamanoApr 19, 2016
  3. Luke DiamandApr 19, 2016
  4. Junio C HamanoApr 19, 2016
  5. Jan DurovecApr 19, 2016
  6. Junio C HamanoApr 19, 2016
  7. Jan DurovecApr 19, 2016
  8. Junio C HamanoApr 19, 2016
  9. Jan DurovecApr 19, 2016
  10. Jan DurovecApr 19, 2016
  11. Junio C HamanoApr 19, 2016
  12. Jan DurovecApr 19, 2016
  13. Junio C HamanoApr 19, 2016
  14. Jan DurovecApr 19, 2016
  15. Luke DiamandApr 20, 2016
  16. Luke DiamandApr 20, 2016
  17. Junio C HamanoApr 20, 2016
  18. Luke DiamandApr 21, 2016
  19. Jan DurovecApr 20, 2016
  20. Junio C HamanoApr 19, 2016
  21. Lars SchneiderApr 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.