Re: [PATCH v2] git-p4: add P4 jobs to git commit message

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 20, 2016, 15:51 UTC
Message-ID: <xmqqtwiwwa5x.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAE5ih7_7TeJDekoubzJ=ZPT_JUwQVyGczDt5yORZES89Qo=VjA@mail.gmail.com>

Luke Diamand <luke@diamand.org> writes:

> One thing I wondered about is whether this should be enabled by
> default or not. Long-time users of git-p4 might be a bit surprised to
> find their git commits suddenly gaining an extra Job: field.

Ahh, I didn't even wonder about but that is not because I didn't think it matters.

Does this change affect reproducibility of importing the history from P4, doesn't it? Would that be a problem?

How common is it to have the "extra" Job: thing in the history on P4 side? If the answer to this question is "on rare occasions and only when there is a very good reason to have 'jobs' associated with the changelist", then the 'might be a bit surprised' brought by this change can probably be explained away as "a fix to a (design) bug that used to discard crucial information" that (unfortunately) have to change the resulting Git object names.