Re: [PATCH v2] git-p4: add P4 jobs to git commit message

From: Jan Durovec <jan.durovec@gmail.com>
Date: Apr 20, 2016, 16:30 UTC
Message-ID: <CABEqOBwGLom5n61+qnK7uhJMhVs4CeFY7aSXPm1xWvmH8RX2Lg@mail.gmail.com>
In-Reply-To: <CAE5ih7_7TeJDekoubzJ=ZPT_JUwQVyGczDt5yORZES89Qo=VjA@mail.gmail.com>

> One thing I wondered about is whether this should be enabled by
> default or not. Long-time users of git-p4 might be a bit surprised to
> find their git commits suddenly gaining an extra Job: field.

I thought about that too when but then I realized that there's no switch for the reverse direction either. I.e. when committing to p4 from git the commit messages are parsed and "Jobs: ..." section is interpreted regardless of any switch, isn't it?

That's why I decided to keep this behaviour symmetrical. Otherwise I would have reused the same switch that enables/disables job parsing in git->p4 direction.