Re: [PATCH v2] git-p4: add P4 jobs to git commit message

From: Luke Diamand <luke@diamand.org>
Date: Apr 20, 2016, 07:58 UTC
Message-ID: <CAE5ih7_7TeJDekoubzJ=ZPT_JUwQVyGczDt5yORZES89Qo=VjA@mail.gmail.com>
In-Reply-To: <xmqqzispxoqt.fsf@gitster.mtv.corp.google.com>

On 19 April 2016 at 22:39, Junio C Hamano <gitster@pobox.com> wrote:

Show 21 quoted lines

> Jan Durovec <jan.durovec@gmail.com> writes:
>
>> On Tue, Apr 19, 2016 at 11:09 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>
>>> For a series this small it does not matter, but anything longer it
>>> would be easier to review with a cover letter (i.e. [PATCH 0/N]).  I
>>> do not know if submitGit lets us do that, though.
>>
>> There's a comment on PR itself (in addition to individual commits) so
>> theoretically it could.
>>
>> It seems that for [PATCH ... n/m] e-mails the commit messages are used,
>> so there's no reason why the PR comment couldn't be used for a cover
>> letter.
>>
>> In this case the PR comment was the same as for one of the commits.
>> Maybe submitGit tried to be smart there? Or maybe it just really
>> doesn't support it (yet?).
>
> In any case, I've queued the updated ones as they looked good.
> Thanks.

One thing I wondered about is whether this should be enabled by default or not. Long-time users of git-p4 might be a bit surprised to find their git commits suddenly gaining an extra Job: field.

Luke