Re: [PATCH v3 2/4] cat-file: introduce the --filters option
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 12 quoted lines
>> In other words, instead of trying to be consistent by erroring out
>> in non-regular blob case, I think the attached change on top would
>> make more sense, by consistently passing the object contents as-is
>> for all "not filtered" cases, whether it is run from the batch mode
>> or from the command line.
>> ...
>> + if ((type == OBJ_BLOB) && S_ISREG(mode)) {
>> struct strbuf strbuf = STRBUF_INIT;
>> if (convert_to_working_tree(path, *buf, *size, &strbuf)) {
>> free(*buf);
>
> Yes, that makes most sense to me, too.Alright; will squash it in then before merging it down to 'next'.