Re: [PATCH v2 0/4] cat-file: optionally convert to worktree version
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 24, 2016, 17:55 UTC
- Message-ID
- <xmqqa8g2qcf3.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160824173248.ami3hgadea5zjvf3@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> I don't suppose anybody cares that much either way, but it feels weird > to behave differently depending on how we looked up the blob (whereas > for the HEAD:t case, a tree is always a tree).
I do not care strongly either way, but HEAD:RelNotes case we _know_ it is not a regular blob, and discarding that info for the sake of being consistent with the common denominator case, instead of using it to point out a possible mistake, feels wrong, too.
In any case, not outputting anything and silently succeeding is definitely wrong ;-).