Re: [PATCH 4/4] cat-file: support --textconv/--filters in batch mode
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Aug 19, 2016, 13:11 UTC
- Message-ID
- <alpine.DEB.2.20.1608191510060.4924@virtualbox>
- In-Reply-To
- <xmqqoa4p4rua.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Thu, 18 Aug 2016, Junio C Hamano wrote:
Show 25 quoted lines
> Jeff King <peff@peff.net> writes: > > > On Thu, Aug 18, 2016 at 02:46:28PM +0200, Johannes Schindelin wrote: > > > >> With this patch, --batch can be combined with --textconv or --filters. > >> For this to work, the input needs to have the form > >> > >> <object name><single white space><path> > >> > >> so that the filters can be chosen appropriately. > > > > The object name can have spaces in it, too. E.g.: > > > > HEAD:path with spaces > > > > or even: > > > > :/grep for this > > When I wrote my review, I didn't consider this use case. > > There is no -z format in --batch, which is unfortunate. If we had > one, it would trivially make it possible to do so, and we can even > have paths with LF in them ;-). On the other hand, producing a NUL > separated input is a chore.
I think it would make for a fine little project to add support for --batch -z.
Just not in this here patch series.
Ciao, Dscho