Re: [PATCH 3/4] cat-file --textconv/--filters: allow specifying the path separately

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 19, 2016, 16:11 UTC
Message-ID: <xmqqy43s3fin.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1608191521410.4924@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 7 quoted lines

>> I think I saw some code to ensure "when giving this option you need
>> that option in effect, too"; they should be tested here, too, no?
>
> No, I would rather not test for that. These conditionals are purely for
> any user's convenience, in case they specify an option that has no effect.
> They are absolutely not essential for the function introduced in this
> patch series.

I didn't say "you would want to test these, no?", did I?

I do not want to see bugreports that say "I wanted to use this new feature and by mistake gave only --path without giving --filter; Git should have complained. I found a bug, hooray!" when somebody in the future refactors the command line option parsing and breaks the check you already have.