Re: [PATCH 2/4] cat-file: introduce the --filters option

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 19, 2016, 12:37 UTC
Message-ID: <alpine.DEB.2.20.1608191426470.4924@virtualbox>
In-Reply-To: <20160818154908.GB17141@tb-raspi>

Hi Torsten,

On Thu, 18 Aug 2016, Torsten Bögershausen wrote:

Show 7 quoted lines

> On Thu, Aug 18, 2016 at 02:46:17PM +0200, Johannes Schindelin wrote:
> > As suggested by its name, the --filters option applies the filters
> 
> []
> > diff --git a/t/t8010-cat-file-filters.sh b/t/t8010-cat-file-filters.sh
>
> Does it make sense to integrate tests into t1006-cat-file ?

t1006 is already a 500+ line script, running 110 cases in 13 seconds over here. I really rather have a new, small, concise and parallelizable script.

Show 8 quoted lines

> > +test_expect_success 'no filters with `git show`' '
> > +	git show HEAD:world.txt >actual &&
>
> I would prefer to have something using
>   cat >expect <<-\EOF &&
>   xxx
>   test_cmp expect actual
> to make it easier to debug in case of a failure ?

Actually, I find it much harder to debug these "the output must match these precise bytes, else we fail" type of test cases. Instead, I describe in a natural way what is expected:

	! has_cr actual

Now, when the test fails, whoever is that poor soul tasked with debugging and fixing the breakage knows *what* goes wrong, conceptually.

So I do not think it would be a good idea to change the test in the way you requested.

And now I have a request of my own. When you quote parts of my mail, you insert your answers without surrounding them by empty lines. That makes it extraordinarily hard for me to read your mails (in fact, I almost missed your second comment).

Could you please start surrounding your replies by empty lines?

Thank you, Dscho