Re: [PATCH v7 6/9] ssh signing: verify signatures using ssh-keygen

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 3, 2021, 23:47 UTC
Message-ID: <xmqqzgtyrszl.fsf@gitster.g>
In-Reply-To: <dc092c7979618d252f7a5a0a5bbe497d8011fd5b.1627998358.git.gitgitgadget@gmail.com>

"Fabian Stelzer via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 14 quoted lines

> diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
> index 2d1f97e1ca7..05dc8e160f8 100644
> --- a/builtin/receive-pack.c
> +++ b/builtin/receive-pack.c
> @@ -131,6 +131,10 @@ static int receive_pack_config(const char *var, const char *value, void *cb)
>  {
>  	int status = parse_hide_refs_config(var, value, "receive");
>  
> +	if (status)
> +		return status;
> +
> +	status = git_gpg_config(var, value, NULL);
>  	if (status)
>  		return status;

Hmph, it feels a bit odd for a misconfigured "transfer.hiderefs" to prevent GPG related configuration from getting read, but is this because a failure from receive_pack_config() will immediately kill the process without doing any harm to the system? If so, the code is good as written.