Re: [PATCH v3 3/9] ssh signing: retrieve a default key from ssh-agent

From: Han-Wen Nienhuys <hanwen@google.com>
Date: Jul 15, 2021, 07:49 UTC
Message-ID: <CAFQ2z_POEE3F_WPAPy4YRRnZONvsg=MOPmti2YT0me+M7eLFvA@mail.gmail.com>
In-Reply-To: <xmqqr1g0ve8w.fsf@gitster.g>

On Wed, Jul 14, 2021 at 10:20 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 7 quoted lines

> > calls ssh-add -L and uses the first key
>
> > +/* Returns the first public key from an ssh-agent to use for signing */
> > +static char *get_default_ssh_signing_key(void) {
>
> Style.  Open and close braces around a function sit on their own
> lines by themselves.

I recommend using clang-format (there is a config file checked into the tree) which handles most formatting conventions automatically.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado