Re: [PATCH v3 3/9] ssh signing: retrieve a default key from ssh-agent

From: Fabian Stelzer <fs@gigacodes.de>
Date: Jul 15, 2021, 08:06 UTC
Message-ID: <ddaf5adf-9219-f462-70ee-ce53ac5d3cf9@gigacodes.de>
In-Reply-To: <CAFQ2z_POEE3F_WPAPy4YRRnZONvsg=MOPmti2YT0me+M7eLFvA@mail.gmail.com>

On 15.07.21 09:49, Han-Wen Nienhuys wrote:

Show 8 quoted lines

> On Wed, Jul 14, 2021 at 10:20 PM Junio C Hamano <gitster@pobox.com> wrote:
>>> calls ssh-add -L and uses the first key
>>> +/* Returns the first public key from an ssh-agent to use for signing */
>>> +static char *get_default_ssh_signing_key(void) {
>> Style.  Open and close braces around a function sit on their own
>> lines by themselves.
> I recommend using clang-format (there is a config file checked into
> the tree) which handles most formatting conventions automatically.

Thanks a lot. This should really be in the in the CodingGuidelines and the MyFirstContribution docs.

Especially the clang-format-diff line from its help "git diff -U0 --no-color --relative HEAD^ | clang-format-diff -p1 -i" is incredibly useful. Otherwise people will reformat all the things ^^