Re: [PATCH v6 6/9] ssh signing: add test prereqs

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 29, 2021, 19:57 UTC
Message-ID: <xmqqsfzw51wq.fsf@gitster.g>
In-Reply-To: <YQL8+UFtVJPlJroe@google.com>

Josh Steadmon <steadmon@google.com> writes:

Show 11 quoted lines

>> ...
>> +GOOD_SIGNATURE_UNTRUSTED='Good "git" signature with'
>> +KEY_NOT_TRUSTED="No principal matched"
>> +BAD_SIGNATURE="Signature verification failed"
>> +
>
> Is there a reason why we don't use these variables in the script above?
>
> Also, in general I feel that it's better to add tests in the same commit
> where new features are added, rather than having standalone test
> commits.

Again, good suggestions.

Thanks for excellent reviews.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.