Re: pre-v2.34.0-rc0 regressions: 'git log' has a noisy iconv() warning
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 28, 2021, 19:02 UTC
- Message-ID
- <xmqqzgqtq8g0.fsf@gitster.g>
- In-Reply-To
- <YXreMYZrTCUkpHXz@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 9 quoted lines
>> I am all for making it convenient to squelch, but it would be sad to >> lose the convenient way to notice possible misencoding in recent >> commits. Or can we have a command line option and pass it through >> the callchain, or would that be too involved? > > Do you mean a command-line option to squelch the warnings? I think it > would not be too hard to do it as a config option (which is probably > what you'd want anyway, since historical commits would come up over and > over again).
Adding a "git -c please.be.verbose.on.encoding.errors=true" is sufficient for those who want to diagnose, but that is not very discoverable. Swapping the polarity and making it verbose by default, with a knob to squelch, may be more practical from that point of view.