pre-v2.34.0-rc0 regressions: 'git log' has a noisy iconv() warning (was: What's cooking in git.git (Oct 2021, #06; Mon, 25))

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Oct 26, 2021, 11:15 UTC
Message-ID: <211026.86y26gyqui.gmgdl@evledraar.gmail.com>
In-Reply-To: <xmqq5ytkzbt7.fsf@gitster.g>

On Mon, Oct 25 2021, Junio C Hamano wrote:

> The fifteenth batch of topics are in 'master'.  I expect that this
> is more-or-less what we can expect in the -rc0, unless there is a
> hotfix to what's already merged.

I suggested a way forward for these iconv warnings that will be new in 2.34.0 at [1], poked'd a few days ago at [2].

Jeff: What do you think? Per [1] I think it's best to drop it entirely
for now, or split out just the "completely unknown encoding" problem
from "can't decode this particular thing".

You also had a patch in [3] that wasn't picked up, which would warn about this once.

If we *are* going to warn that seems like the worst of both in some sense, i.e. we'll no longer give users anything like "in this huge commit stream, we couldn't search in commit XYZ", instead we just warn on whatever happens to be the first commit, and you'll have no idea if subsequent matches were completed or not.

1. https://lore.kernel.org/git/871r4umfnm.fsf@evledraar.gmail.com/
2. https://lore.kernel.org/git/211023.86sfwsis1i.gmgdl@evledraar.gmail.com/
3. https://lore.kernel.org/git/YWEBmJk0aENR5Yeo@coredump.intra.peff.net/