Re: What's cooking in git.git (Oct 2021, #06; Mon, 25)

From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date: Oct 31, 2021, 18:36 UTC
Message-ID: <1575aeb5-7aec-3d5c-6b2c-11b9866f3f4c@gmail.com>
In-Reply-To: <YXeRNkO8B4TP/cau@coredump.intra.peff.net>

On 26/10/21 10:55 am, Jeff King wrote:

Show 13 quoted lines

> On Mon, Oct 25, 2021 at 08:48:04PM -0700, Junio C Hamano wrote:
> 
>> * ks/submodule-add-message-fix (2021-10-23) 1 commit
>>    (merged to 'next' on 2021-10-25 at 377e759528)
>>   + submodule--helper: fix incorrect newlines in an error message
>>
>>   Message regression fix.
>>
>>   Will merge to 'master'.
> 
> This commit has an extra unused parameter in the helper function. I
> think we'd want the patch below on top.
>

Sorry for the oversight and thanks for catching it (again)!

This reminded me to check my config.mak and enable DEVELOPER=1 which I seem to have turned off for some reason. I did notice we explicitly add -Wno-unused-parameter to DEVELOPER_CFLAGS (likely with good reason). The rest of the flags should be helpful though :)

-- 
Sivaraam