Re: [RFC PATCH v2 4/7] parse: create new library for parsing strings and env values

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 14, 2023, 22:19 UTC
Message-ID: <xmqqzg2tjmgu.fsf@gitster.g>
In-Reply-To: <20230814220910.60930-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 7 quoted lines

> Thanks - I think that patches 1 through 4 are worth merging even now.
> One thing we hoped to accomplish through the libification effort is to
> make changes that are beneficial even outside the libification context,
> and it seems that this is one of them. Previously, code needed to
> include config.h even when it didn't use the main functionality that
> config.h provides (config), but now it no longer needs to do so. (And
> same argument for hex, although on a smaller scale.)

Thanks for writing this down. The parser is shared across handling data that come from config, environ, and options, and separating it as a component different from the config does make sense.