Re: [PATCH v4 2/4] wrapper: reduce scope of remove_or_warn()

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 10, 2023, 16:13 UTC
Message-ID: <xmqqjzruv4k1.fsf@gitster.g>
In-Reply-To: <066b3162-6a81-45d7-b164-17b74e6c92dc@gmail.com>

phillip.wood123@gmail.com writes:

Show 19 quoted lines

> Hi Jonathan
>
> On 29/09/2023 22:20, Jonathan Tan wrote:
>> From: Calvin Wan <calvinwan@google.com>
>> remove_or_warn() is only used by entry.c and apply.c, but it is
>> currently declared and defined in wrapper.{h,c}, so it has a scope much
>> greater than it needs. This needlessly large scope also causes wrapper.c
>> to need to include object.h, when this file is largely unconcerned with
>> Git objects.
>> Move remove_or_warn() to entry.{h,c}. The file apply.c still has
>> access
>> to it, since it already includes entry.h for another reason.
>
> This looks good. On a related note wrapper.c includes repository.h but
> does use anything declared in that header.
>
> Best Wishes
>
> Phillip

Thanks for a review. I just checked 'master', 'next', and 'seen' and in all '#include <repository.h>' can safely be dropped from there, it seems. It may be too trivial even for a microproject, but nevertheless a nice clean-up.