Re: [PATCH v3 2/6] wrapper: remove dependency to Git-specific internal file

From: Jonathan Tan <jonathantanmy@google.com>
Date: Sep 15, 2023, 17:54 UTC
Message-ID: <20230915175425.1585455-1-jonathantanmy@google.com>
In-Reply-To: <20230908174443.1027716-2-calvinwan@google.com>

Calvin Wan <calvinwan@google.com> writes:

Show 6 quoted lines

> In order for wrapper.c to be built independently as part of a smaller
> library, it cannot have dependencies to other Git specific
> internals. remove_or_warn() creates an unnecessary dependency to
> object.h in wrapper.c. Therefore move the function to entry.[ch] which
> performs changes on the worktree based on the Git-specific file modes in
> the index.

Looking at remove_or_warn(), it's only used from entry.c and apply.c (which already includes entry.h for another reason) so moving it to entry.c looks fine.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.