Re: [PATCH 3/7] trace: use warning() for printing trace errors
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 4, 2016, 21:28 UTC
- Message-ID
- <xmqqy44cz0k6.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160804212157.cn7ecyxcbyf4okd7@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> I wondered if that would then let us drop set_warn_routine(), but it > looks like there are other warning() calls it cares about. So that would > invalidate the last paragraph here, though I still think converting the > trace errors to warning() is a reasonable thing to do.
Yes. That is why tonight's pushout will have this series in 'jch' (that is a point on a linear history between 'master' and 'pu') and tentatively ejects cc/apply-am topic out of 'pu', expecting it to be rerolled.
Thanks.