[PATCH 0/7] minor trace fixes and cosmetic improvements

From: Jeff King <peff@peff.net>
Date: Aug 3, 2016, 22:56 UTC
Message-ID: <20160803225600.fgm23bdacunmrw44@sigill.intra.peff.net>
In-Reply-To: <20160803213920.jg3eshy57bsldqjh@sigill.intra.peff.net>

On Wed, Aug 03, 2016 at 05:39:20PM -0400, Jeff King wrote:

Show 7 quoted lines

> Thinking about (2), I'd go so far as to say that the trace actually
> should just be using:
> 
>   if (write_in_full(...) < 0)
> 	warning("unable to write trace to ...: %s", strerror(errno));
> 
> and we should get rid of write_or_whine_pipe entirely.

I started to write a patch to do that, but it turns out the trace code is full of bugs (and opportunities for cosmetic improvements).

Here's what I came up with.

  [1/7]: trace: handle NULL argument in trace_disable()
  [2/7]: trace: stop using write_or_whine_pipe()
  [3/7]: trace: use warning() for printing trace errors
  [4/7]: trace: cosmetic fixes for error messages
  [5/7]: trace: correct variable name in write() error message
  [6/7]: trace: disable key after write error
  [7/7]: write_or_die: drop write_or_whine_pipe()

-Peff