Re: [PATCH 4/7] trace: cosmetic fixes for error messages

From: Jeff King <peff@peff.net>
Date: Aug 5, 2016, 08:00 UTC
Message-ID: <20160805080016.tne7lvvvaw3viot2@sigill.intra.peff.net>
In-Reply-To: <xmqqfuqk1d23.fsf@gitster.mtv.corp.google.com>

On Thu, Aug 04, 2016 at 01:42:12PM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > I think it would be nicer to still to print:
> >
> >  warning: first line
> >  warning: second line
> >
> > etc. We do that for "advice:", but not the rest of the vreportf
> > functions. It might be nice to do that, but we'd have to go back to
> > printing into a buffer (since we can't break up the incoming format
> > string that we feed to fprintf).
> 
> Yes, yes.

Actually, I guess in this case we could easily do:

   warning("something");
   warning("something else");

etc (the lines are fairly stand-alone, so I don't think it runs afoul of the usual translator-lego problem; not to mention that these aren't actually translated). I don't really care that much between that and the indented output, but if there's a preference, I'm happy to re-roll with that.

-Peff