Re: [PATCH v2 08/11] i18n: send-email: mark strings for translation
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 25, 2016, 23:18 UTC
- Message-ID
- <xmqqy42fwotm.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1472646690-9699-9-git-send-email-vascomalmeida@sapo.pt>
Vasco Almeida <vascomalmeida@sapo.pt> writes:
Show 6 quoted lines
> @@ -1403,7 +1412,7 @@ Message-Id: $message_id
> if ($quiet) {
> printf (($dry_run ? "Dry-" : "")."Sent %s\n", $subject);
> } else {
> - print (($dry_run ? "Dry-" : "")."OK. Log says:\n");
> + print (($dry_run ? "Dry-" : ""). __("OK. Log says:\n"));I am not sure about this change. We either say Dry-Sent/Dry-OK (under --dry-run) or "Sent/OK"; don't you want "dry-" part also translated?